Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Integrate ThreatsDataViews Component #40076

Draft
wants to merge 2 commits into
base: add/protect/core
Choose a base branch
from

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Nov 6, 2024

Proposed changes:

  • Replaces the custom threats sidebar and accordion with the new ThreatsDataViews component.
  • Removes the separate implementation of /scan/history and /scan/history/:status, but maintains support for those URL paths by automatically applying the history filter to the main /scan route component on load.
  • Moves assorted types and utilities up into the @automattic/jetpack-scan package.
  • Ensures fixer API responses are camelized for consistency.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

peb6dq-31T-p2

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Go to /wp-admin/admin.php?page=jetpack-protect
  • Thoroughly test the scan tab:
    • View free and paid threat results, as well as empty states.
    • Test auto-fixers.
    • Test loading the page via /scan/history and/or /scan/history/fixed.

Screenshots:

Screenshot 2024-11-08 at 10 35 24 AM

@nateweller nateweller self-assigned this Nov 6, 2024
@nateweller nateweller requested a review from a team November 6, 2024 20:38
@github-actions github-actions bot added [Package] Protect Models [Package] Protect Status [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Tests] Includes Tests labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@nateweller nateweller force-pushed the add/protect/threats-data-views branch from 8053c3f to ea8b837 Compare November 6, 2024 20:45
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect/threats-data-views branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/protect/threats-data-views
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/threats-data-views
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@nateweller nateweller force-pushed the add/protect/threats-data-views branch 5 times, most recently from 9634495 to d5226e6 Compare November 8, 2024 17:10
@nateweller nateweller changed the base branch from trunk to update/protect-status-format November 8, 2024 17:10
@github-actions github-actions bot added [Block] Subscriptions [mu wpcom Feature] Wpcom Global Styles [Package] Jetpack mu wpcom WordPress.com Features [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] Sync [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. Admin Page React-powered dashboard under the Jetpack menu Docs labels Nov 8, 2024
@nateweller nateweller force-pushed the add/protect/threats-data-views branch 3 times, most recently from 60c0bb6 to 922fef5 Compare November 8, 2024 17:14
@github-actions github-actions bot added the RNA label Nov 8, 2024
@nateweller nateweller force-pushed the add/protect/threats-data-views branch 2 times, most recently from 9be7cff to a289dc0 Compare November 13, 2024 18:44
Base automatically changed from update/protect-status-format to trunk November 13, 2024 19:28
@nateweller nateweller force-pushed the add/protect/threats-data-views branch 3 times, most recently from faadb22 to ba5eff4 Compare November 13, 2024 20:38
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Nov 13, 2024
@nateweller nateweller changed the base branch from trunk to add/protect/core November 14, 2024 18:22
@nateweller nateweller force-pushed the add/protect/threats-data-views branch 7 times, most recently from 0ebb519 to 3c9aa34 Compare November 15, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Scan [Package] Protect Models [Package] Protect Status [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Status] In Progress [Tests] Includes Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant